Skip to contentSkip to conversation

Change in openvpn[master]: Doxygen: Remove useless Python information

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Apr 9, 2025 – Apr 15, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1744202768000.Ia7186b528773c0549748f1051c1c8d1db39a7e11@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/939?usp=email

to review the following change.

Change subject: Doxygen: Remove useless Python information
......................................................................

Doxygen: Remove useless Python information

Do not include information for the trivial Python scripts we have. Completely eliminates the "Namespaces" page as well.

Change-Id Ia7186b528773c0549748f1051c1c8d1db39a7e11

---
M doc/doxygen/openvpn.doxyfile.in

1 file changed, 1 insertion(+), 30 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/39/939/1

doc/doxygen/openvpn.doxyfile.in +1 -30
index 573b7c2..edecc54 100644
@@ -894,36 +894,7 @@
 # *.ucf, *.qsf and *.ice.
 
 FILE_PATTERNS          = *.c \
-                         *.cc \
-                         *.cxx \
-                         *.cpp \
-                         *.c++ \
-                         *.d \
-                         *.java \
-                         *.ii \
-                         *.ixx \
-                         *.ipp \
-                         *.i++ \
-                         *.inl \
-                         *.h \
-                         *.hh \
-                         *.hxx \
-                         *.hpp \
-                         *.h++ \
-                         *.idl \
-                         *.odl \
-                         *.cs \
-                         *.php \
-                         *.php3 \
-                         *.inc \
-                         *.m \
-                         *.mm \
-                         *.dox \
-                         *.py \
-                         *.f90 \
-                         *.f \
-                         *.vhd \
-                         *.vhdl
+                         *.h
 
 # The RECURSIVE tag can be used to specify whether or not subdirectories should
 # be searched for input files as well.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/939?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia7186b528773c0549748f1051c1c8d1db39a7e11
Gerrit-Change-Number: 939
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/939?usp=email )

Change subject: Doxygen: Remove useless Python information
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
Yeah, we don't care about doxygen from the sample scripts

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/939?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia7186b528773c0549748f1051c1c8d1db39a7e11
Gerrit-Change-Number: 939
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 Doxygen: Remove useless Python information

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Do not include information for the trivial Python scripts we have. Completely eliminates the "Namespaces" page as well.

Change-Id Ia7186b528773c0549748f1051c1c8d1db39a7e11

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/939
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>

doc/doxygen/openvpn.doxyfile.in +1 -30
index 573b7c2..edecc54 100644
@@ -894,36 +894,7 @@
 # *.ucf, *.qsf and *.ice.
 
 FILE_PATTERNS          = *.c \
-                         *.cc \
-                         *.cxx \
-                         *.cpp \
-                         *.c++ \
-                         *.d \
-                         *.java \
-                         *.ii \
-                         *.ixx \
-                         *.ipp \
-                         *.i++ \
-                         *.inl \
-                         *.h \
-                         *.hh \
-                         *.hxx \
-                         *.hpp \
-                         *.h++ \
-                         *.idl \
-                         *.odl \
-                         *.cs \
-                         *.php \
-                         *.php3 \
-                         *.inc \
-                         *.m \
-                         *.mm \
-                         *.dox \
-                         *.py \
-                         *.f90 \
-                         *.f \
-                         *.vhd \
-                         *.vhdl
+                         *.h
 
 # The RECURSIVE tag can be used to specify whether or not subdirectories should
 # be searched for input files as well.
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: Doxygen: Remove useless Python information

And another one - no code change, nothing to test ;-)

Your patch has been applied to the master branch.

commit 78d0c15f48388c0d2376c12be47b0f8be98fac55

Author: Frank Lichtenheld
Date:   Tue Apr 15 17:56:50 2025 +0200
     Doxygen: Remove useless Python information

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg31433.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/939?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by plaisthos

Change subject: Doxygen: Remove useless Python information
......................................................................

Doxygen: Remove useless Python information

Do not include information for the trivial Python scripts we have. Completely eliminates the "Namespaces" page as well.

Change-Id Ia7186b528773c0549748f1051c1c8d1db39a7e11

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31433.html

---
M doc/doxygen/openvpn.doxyfile.in

1 file changed, 1 insertion(+), 30 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/39/939/2

doc/doxygen/openvpn.doxyfile.in +1 -30
index 573b7c2..edecc54 100644
@@ -894,36 +894,7 @@
 # *.ucf, *.qsf and *.ice.
 
 FILE_PATTERNS          = *.c \
-                         *.cc \
-                         *.cxx \
-                         *.cpp \
-                         *.c++ \
-                         *.d \
-                         *.java \
-                         *.ii \
-                         *.ixx \
-                         *.ipp \
-                         *.i++ \
-                         *.inl \
-                         *.h \
-                         *.hh \
-                         *.hxx \
-                         *.hpp \
-                         *.h++ \
-                         *.idl \
-                         *.odl \
-                         *.cs \
-                         *.php \
-                         *.php3 \
-                         *.inc \
-                         *.m \
-                         *.mm \
-                         *.dox \
-                         *.py \
-                         *.f90 \
-                         *.f \
-                         *.vhd \
-                         *.vhdl
+                         *.h
 
 # The RECURSIVE tag can be used to specify whether or not subdirectories should
 # be searched for input files as well.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/939?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia7186b528773c0549748f1051c1c8d1db39a7e11
Gerrit-Change-Number: 939
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/939?usp=email )

Change subject: Doxygen: Remove useless Python information
......................................................................

Doxygen: Remove useless Python information

Do not include information for the trivial Python scripts we have. Completely eliminates the "Namespaces" page as well.

Change-Id Ia7186b528773c0549748f1051c1c8d1db39a7e11

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31433.html

---
M doc/doxygen/openvpn.doxyfile.in

1 file changed, 1 insertion(+), 30 deletions(-)
doc/doxygen/openvpn.doxyfile.in +1 -30
index 573b7c2..edecc54 100644
@@ -894,36 +894,7 @@
 # *.ucf, *.qsf and *.ice.
 
 FILE_PATTERNS          = *.c \
-                         *.cc \
-                         *.cxx \
-                         *.cpp \
-                         *.c++ \
-                         *.d \
-                         *.java \
-                         *.ii \
-                         *.ixx \
-                         *.ipp \
-                         *.i++ \
-                         *.inl \
-                         *.h \
-                         *.hh \
-                         *.hxx \
-                         *.hpp \
-                         *.h++ \
-                         *.idl \
-                         *.odl \
-                         *.cs \
-                         *.php \
-                         *.php3 \
-                         *.inc \
-                         *.m \
-                         *.mm \
-                         *.dox \
-                         *.py \
-                         *.f90 \
-                         *.f \
-                         *.vhd \
-                         *.vhdl
+                         *.h
 
 # The RECURSIVE tag can be used to specify whether or not subdirectories should
 # be searched for input files as well.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/939?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia7186b528773c0549748f1051c1c8d1db39a7e11
Gerrit-Change-Number: 939
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged